fix(GuildEmojiManager): check for guild in methods that use it #4886
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCrawl
approved these changes
Oct 17, 2020
GiorgioBrux
pushed a commit
to GiorgioBrux/discord.js
that referenced
this pull request
Oct 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Client#emojisandGuild#emojisboth return aGuildEmojiManager, however the current code base does not account for former not having a valid guild property.client.emojis.create(...)before resulted inDiscordAPIError: 405: Method Not Allowed, this PR aims to fix that by checking if a guild is present before using it for methods and throwing a custom error.Consideration
There's also the option to create two separate classes for
Client#emojisandGuild#emojis, I've decided to take this approach for now but I'm open to suggestions.Status
Semantic versioning classification: