Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GuildMember#pending #5121

Merged
merged 5 commits into from
Jan 2, 2021
Merged

Add GuildMember#pending #5121

merged 5 commits into from
Jan 2, 2021

Conversation

wasdennnoch
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:

discord/discord-api-docs#2299
Previously (when it was still undocumented) that field was nullable, the new merged docs now say it's always present; however someone already noted that this field is not actually always present. Will update once that has been clarified.

Status

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@wasdennnoch
Copy link
Contributor Author

Docs have been clarified that pending isn't nullable anymore (discord/discord-api-docs@2fe4e62) and may not always be present, in which case the member isn't supposed to be pending anyways. Updated the PR accordingly.

@zaida04 zaida04 mentioned this pull request Dec 29, 2020
Closed
vladfrangu
vladfrangu requested changes Dec 30, 2020
View reviewed changes
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment before, use ??

@iCrawl iCrawl merged commit c4c8171 into discordjs:master Jan 2, 2021
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@iCrawl iCrawl iCrawl approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@Rabustep Rabustep Rabustep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 13
Development

Successfully merging this pull request may close these issues.
6 participants
@wasdennnoch @vladfrangu @iCrawl @kyranet @SpaceEEC @Rabustep