Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(GuildMember): add guild avatars #5696

Merged
merged 3 commits into from
Sep 28, 2021
Merged

feat(GuildMember): add guild avatars #5696

merged 3 commits into from
Sep 28, 2021

Conversation

ImRodry
Copy link
Contributor

@ImRodry ImRodry commented May 29, 2021 •
edited by iCrawl
Loading

Please describe the changes this PR makes and why it should be merged:
This PR adds server avatars to the GuildMember object.

discord-api-docs PR:

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR changes the library's interface (methods or parameters added)

iShibi
iShibi suggested changes May 29, 2021
View reviewed changes
src/structures/GuildMember.js Outdated Show resolved Hide resolved
@kyranet kyranet self-requested a review May 29, 2021 19:49
@ImRodry ImRodry changed the title feat(GuildMember): add server avatars feat(GuildMember): add guild avatars May 29, 2021
GamingGeek
GamingGeek approved these changes May 29, 2021
View reviewed changes
Copy link
Contributor

@GamingGeek GamingGeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

GoldenAngel2
GoldenAngel2 suggested changes May 30, 2021
View reviewed changes
Copy link
Contributor

@GoldenAngel2 GoldenAngel2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GuildAvatar needs to be added to the typings file, Constants -> Endpoints -> CDN

kyranet
kyranet requested changes May 30, 2021
View reviewed changes
src/util/Constants.js Outdated Show resolved Hide resolved
@ImRodry ImRodry requested a review from kyranet May 30, 2021 17:07
@iCrawl
Copy link
Member

iCrawl commented May 31, 2021

This needs a rebase.

@ImRodry
Copy link
Contributor Author

ImRodry commented May 31, 2021

Done!

@ImRodry ImRodry requested a review from vladfrangu June 2, 2021 07:51
@vladfrangu
Copy link
Member

LGTM, however let's wait for Discord first to finalize this 👍

iShibi
iShibi reviewed Jun 12, 2021
View reviewed changes
typings/index.d.ts Outdated Show resolved Hide resolved
almeidx
almeidx requested changes Jun 12, 2021
View reviewed changes
Copy link
Member

@almeidx almeidx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GuildMember#equals should be updated to support this new property

@ImRodry ImRodry marked this pull request as draft June 13, 2021 18:20
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
@ImRodry ImRodry force-pushed the server-avatar branch 2 times, most recently from 0d10016 to fc936dd Compare July 2, 2021 13:22
@iCrawl iCrawl added this to the Version 13.1 milestone Aug 6, 2021
@iCrawl iCrawl removed this from the Version 13.1 milestone Aug 13, 2021
@PuneetGopinath
Copy link

Waiting for this

@kyranet
Copy link
Member

kyranet commented Aug 14, 2021 •
edited
Loading

+1'ing the PR won't make it land faster, this is still an experiment on Discord's side and can change at any moment, @PuneetGopinath

@PuneetGopinath
Copy link

+1'ing the PR won't make it land faster

I was just telling to everyone that I like it

this is still an experiment on Discord's and can change at any moment

Ohk. I didn't know that.

@xiBread xiBread mentioned this pull request Aug 22, 2021
Closed
@ImRodry ImRodry marked this pull request as ready for review September 27, 2021 18:35
@ImRodry
Copy link
Contributor Author

ImRodry commented Sep 27, 2021

Upstream PR has finally been merged!

ImRodry and others added 2 commits September 27, 2021 19:37
@ImRodry @NotSugden @iShibi
feat(GuildMember): add per-guild avatars
58a0785 
Co-Authored-By: Sugden <28943913+NotSugden@users.noreply.github.com>
Co-Authored-By: Shubham Parihar <shubhamparihar391@gmail.com>
@ImRodry
types(GuildMember): add back avatar methods/properity
6c28d17
GoldenAngel2
GoldenAngel2 suggested changes Sep 27, 2021
View reviewed changes
src/util/Constants.js Outdated Show resolved Hide resolved
@ImRodry @GoldenAngel2
refactor(Constants): better if check
3133be7 
Co-authored-by: GoldenAngel <50855202+GoldenAngel2@users.noreply.github.com>
@iCrawl iCrawl added this to the Version 13.2 milestone Sep 28, 2021
@iCrawl iCrawl merged commit dfd7b40 into discordjs:main Sep 28, 2021
@ImRodry ImRodry deleted the server-avatar branch September 28, 2021 16:54
AAGaming00 pushed a commit to aa-forks/better-discord.js that referenced this pull request May 21, 2022
backport discordjs#5696
998cddc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iShibi iShibi iShibi requested changes

@austr1an austr1an austr1an left review comments

@GoldenAngel2 GoldenAngel2 GoldenAngel2 requested changes

@almeidx almeidx almeidx requested changes

@NotSugden NotSugden NotSugden requested changes

@xhyrom xhyrom xhyrom approved these changes

@Mysterious-Dev Mysterious-Dev Mysterious-Dev approved these changes

@cosmicle0 cosmicle0 cosmicle0 approved these changes

@Sant268 Sant268 Sant268 approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@kyranet kyranet kyranet approved these changes

@iCrawl iCrawl iCrawl approved these changes

@vladfrangu vladfrangu vladfrangu approved these changes

@GamingGeek GamingGeek GamingGeek approved these changes

Assignees
No one assigned
Labels
api support semver:minor
Projects
None yet
Milestone
Version 13.2
Development

Successfully merging this pull request may close these issues.