Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(presenceUpdate): fire when only state/details change on an activity #5846

Merged
merged 4 commits into from
Jun 19, 2021
Merged

Conversation

JMTK
Copy link
Contributor

@JMTK JMTK commented Jun 13, 2021

Please describe the changes this PR makes and why it should be merged:
Add support for firing presence update events when the only thing that changes is an activity's state or details.

Fixes #5845

Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating

Add support for firing presence update events when the only thing that changes is an activity's state or details.

Fixes #5845
@JMTK JMTK changed the title Update Presence.js Allow presenceUpdate to fire when only state/details change on an activity Jun 13, 2021
Copy link
Member

@vladfrangu vladfrangu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you fix lint? Otherwise, if details isn't an object (in which case you'll need to check its keys), LGTM

JMTK added 3 commits June 15, 2021 10:13
Can't have too many characters on one line
Add proper spacing
@JMTK
Copy link
Contributor Author

JMTK commented Jun 15, 2021

Sorry about that! There was an extra space that the lint was complaining about that I had missed. Should be good now!

@iCrawl iCrawl changed the title Allow presenceUpdate to fire when only state/details change on an activity fix(presenceUpdate): fire when only state/details change on an activity Jun 19, 2021
@iCrawl iCrawl merged commit 1f8f3ab into discordjs:master Jun 19, 2021
@iCrawl iCrawl added this to the Version 13 milestone Jun 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Presence updates on some activities are skipped
5 participants