-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(CommandInteractionResolvedData): access to "raw" resolved data #6384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jiralite
requested changes
Aug 11, 2021
Jiralite
reviewed
Aug 11, 2021
monbrey
commented
Aug 11, 2021
vladfrangu
requested changes
Aug 11, 2021
vladfrangu
approved these changes
Aug 11, 2021
iCrawl
approved these changes
Aug 11, 2021
Jiralite
reviewed
Aug 11, 2021
kyranet
approved these changes
Aug 11, 2021
NotSugden
reviewed
Aug 11, 2021
monbrey
commented
Aug 12, 2021
Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
monbrey
commented
Aug 12, 2021
monbrey
commented
Aug 12, 2021
SpaceEEC
approved these changes
Aug 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the absence of a good way to expose individual resolved data as "mentions", this exposed the complete, parsed
interaction.data.resolved
object as a number of Collections, similar to how MessageMentions are provided.Aim is to do this in a non-breaking way for 13.1.0, hence using the "resolved" property name, leaving "mentions" available if we want to do a better filtering of it somewhere else down the track.
Status and versioning classification: