-
-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Guild): Add Guild#maximumBitrate
getter.
#6455
Merged
iCrawl
merged 12 commits into
discordjs:main
from
fasterplayer:Maximum-bitrate-on-guild
Aug 23, 2021
Merged
feat(Guild): Add Guild#maximumBitrate
getter.
#6455
iCrawl
merged 12 commits into
discordjs:main
from
fasterplayer:Maximum-bitrate-on-guild
Aug 23, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shouldn't this be a getter? |
I'll update it later today. |
fasterplayer
changed the title
feat(Guild): Add
feat(Guild): Add Aug 17, 2021
Guild#maximumBitrate
property.Guild#maximumBitrate
getter.
Updated into a getter! Thanks for the advice. I'm new to this and trying to help the best i can! |
Jiralite
requested changes
Aug 17, 2021
Jiralite
reviewed
Aug 17, 2021
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
…layer/discord.js into Maximum-bitrate-on-guild
kyranet
previously requested changes
Aug 17, 2021
NotSugden
suggested changes
Aug 17, 2021
kevinbioj
reviewed
Aug 17, 2021
NotSugden
reviewed
Aug 17, 2021
Never used a switch like this. Nice to know! Co-authored-by: Sugden <28943913+NotSugden@users.noreply.github.com>
kyranet
requested changes
Aug 18, 2021
Co-authored-by: Antonio Román <kyradiscord@gmail.com>
kyranet
approved these changes
Aug 18, 2021
iCrawl
approved these changes
Aug 18, 2021
vladfrangu
requested changes
Aug 23, 2021
vladfrangu
approved these changes
Aug 23, 2021
SpaceEEC
approved these changes
Aug 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
This PR adds a getter to Guild which indicates the maximum allowed bitrate in this guild.
This is similar to the
ThreadAutoArchiveDuration['MAX']
option.Status and versioning classification: