feat(Interaction): add memberPermissions #6741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImRodry
reviewed
Oct 2, 2021
ImRodry
suggested changes
Oct 2, 2021
Co-authored-by: Rodry <38259440+ImRodry@users.noreply.github.com>
Jiralite
reviewed
Oct 2, 2021
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com>
SpaceEEC
approved these changes
Oct 3, 2021
vladfrangu
approved these changes
Oct 3, 2021
ImRodry
approved these changes
Oct 3, 2021
iCrawl
approved these changes
Oct 3, 2021
ObscuritySRL
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Implements
<Interaction>.member.permissions, if exists, sent with an interaction.nullif the interaction was sent via DM.Attempting to fetch an uncached channel without
VIEW_CHANNELwill result in aMissing Accesserror. However, interactions can still be received and responded to in channels which a bot does not haveVIEW_CHANNELfor. Unless we use<Interaction>.member.permissionssent with the interaction , it's impossible to get the permissions of a member in an uncached channel.Large bots which cannot afford to cache tens of millions of channels, roles, and permissions, could rely on the permissions sent with the interaction.
Status and versioning classification: