Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

consistency in audit logs owo #1431

Merged
merged 1 commit into from
Apr 29, 2017
Merged

consistency in audit logs owo #1431

merged 1 commit into from
Apr 29, 2017

Conversation

devsnek
Copy link
Member

@devsnek devsnek commented Apr 29, 2017

  • docblock updated because to the end user they aren't promises
  • used Target variables because consistancy

@devsnek devsnek changed the title owo consistancy in audit logs owo Apr 29, 2017
@devsnek devsnek changed the title consistancy in audit logs owo consistency in audit logs owo Apr 29, 2017
@amishshah
Copy link
Member

mfw
fairscalycavy

@devsnek
Copy link
Member Author

devsnek commented Apr 29, 2017 •
edited
Loading

Please describe the changes this PR makes and why it should be merged:

  • docblock updated because to the end user they aren't promises
  • used Target variables because consistancy

Semantic versioning classification:

  • This PR changes the library's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to documentation, README, etc.
  • this PR changes some documentation, but also some code, but nothing external or breaking, so the stuff above can't be checked

@devsnek
Copy link
Member Author

devsnek commented Apr 29, 2017

@hydrabolt u happy now???? ARE YOU HAPPY NOW????????

@amishshah amishshah merged commit 6f96cf7 into discordjs:master Apr 29, 2017
@devsnek devsnek deleted the patch-2 branch April 29, 2017 23:36
@amishshah
Copy link
Member

I'm not HAPPY WITH THIS ATTITUDE, MISTER

@PgBiel PgBiel mentioned this pull request May 1, 2017
Merged
@iCrawl iCrawl added t: REST and removed t: utility labels May 1, 2017
devsnek added a commit to devsnek/discord.js that referenced this pull request May 14, 2017
@devsnek @amishshah
Use Target variables for consistency (discordjs#1431)
eab2f34
Ratismal pushed a commit to Ratismal/discord.js that referenced this pull request Jul 5, 2017
@devsnek @Ratismal
Use Target variables for consistency (discordjs#1431)
6a534a5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@devsnek @amishshah @iCrawl