update GuildAuditLogs for MESSAGE_DELETE and fixed extras #1464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you try to make some documentation for extras? 🤢 |
devsnek
reviewed
May 5, 2017
src/structures/GuildAuditLogs.js
Outdated
| @@ -4,6 +4,7 @@ const Snowflake = require('../util/Snowflake'); | |||
| const Targets = { | |||
| GUILD: 'GUILD', | |||
| CHANNEL: 'CHANNEL', | |||
| MESSAGE: 'MESSAGE', | |||
| USER: 'USER', | |||
| ROLE: 'ROLE', | |||
| INVITE: 'INVITE', | |||
There was a problem hiding this comment.
can you move message to the bottom so they are in order of type mod 10
There was a problem hiding this comment.
Ah, that's the way they are sorted.
iCrawl
pushed a commit
that referenced
this pull request
May 5, 2017
* update GuildAuditLogs for MESSAGE_DELETE and fixed extras * correct oder of targets
devsnek
pushed a commit
to devsnek/discord.js
that referenced
this pull request
May 14, 2017
…1464) * update GuildAuditLogs for MESSAGE_DELETE and fixed extras * correct oder of targets
devsnek
pushed a commit
to devsnek/discord.js
that referenced
this pull request
May 14, 2017
…1464) * update GuildAuditLogs for MESSAGE_DELETE and fixed extras * correct oder of targets
Ratismal
pushed a commit
to Ratismal/discord.js
that referenced
this pull request
Jul 5, 2017
…1464) * update GuildAuditLogs for MESSAGE_DELETE and fixed extras * correct oder of targets
This was referenced Aug 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
I am not sure whether
target < 80is correct, it just seemed logical to me.this.optionsshould bedata.optionsShouldn't at least GuildAudLogs.build be private, if not all methods?
Semantic versioning classification: