feat(Webhook): add type property and created* getters #3585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpaceEEC
changed the title
MBR-0001
approved these changes
Nov 19, 2019
Co-Authored-By: Gryffon Bellish <owenbellish@gmail.com>
PyroTechniac
approved these changes
Nov 19, 2019
MBR-0001
approved these changes
Nov 20, 2019
1 task
|
since the linked commit also introduces the documentation for token to be nullable shouldn't that also be incorporated both into the docs as well as typings? ref |
iCrawl
approved these changes
Dec 25, 2019
SpaceEEC
added a commit
to SpaceEEC/discord.js
that referenced
this pull request
Jan 18, 2020
5 tasks
samsamson33
pushed a commit
to samsamson33/discord.js
that referenced
this pull request
Feb 27, 2020
* feat(Webhook): add created* getters * feat(Webhook): add type property * typings(WebhookFields): use primitive string for url getter Co-Authored-By: Gryffon Bellish <owenbellish@gmail.com> * fix(Webhook): token can be null Co-authored-by: Gryffon Bellish <owenbellish@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Resolves #3605
This PR adds
Webhook#typeto distinguish between incoming and channel follower webhooks.See: discord/discord-api-docs@b36723b
It also adds
createdAtandcreatedTimestamptoWebhookand adds those, as well asurl, to the list of applied properties toWebhookClient.Status
Semantic versioning classification: