Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: use consistent naming for options #8901

Merged
merged 6 commits into from
Dec 14, 2022
Merged

refactor: use consistent naming for options #8901

merged 6 commits into from
Dec 14, 2022

Conversation

MrMythicalYT
Copy link
Contributor

Please describe the changes this PR makes and why it should be merged:
This PR refactors the XOptions/XData interfaces to all follow the same format

Create options format: StructureCreateOptions
Edit options format: StructureEditOptions
Status and versioning classification:

  • Code changes have been tested against the Discord API, or there are no code changes
  • I know how to update typings and have done so, or typings don't need updating
  • This PR only includes non-code changes, like changes to documentation, README, etc.

@vercel
Copy link

vercel bot commented Dec 3, 2022 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Updated
discord-js ⬜️ Ignored (Inspect) Dec 14, 2022 at 9:29PM (UTC)
discord-js-guide ⬜️ Ignored (Inspect) Dec 14, 2022 at 9:29PM (UTC)

@Jiralite Jiralite added this to the discord.js v14.8 milestone Dec 3, 2022
@MrMythicalYT @SpaceEEC
Update packages/discord.js/src/structures/Guild.js
90a10ed 
Co-authored-by: SpaceEEC <spaceeec@yahoo.com>
suneettipirneni
suneettipirneni approved these changes Dec 8, 2022
View reviewed changes
Copy link
Member

@suneettipirneni suneettipirneni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://discord.com/channels/222078108977594368/222197033908436994/1050237009974796309

@kodiakhq kodiakhq bot merged commit a7b55c1 into discordjs:main Dec 14, 2022
@Jiralite Jiralite mentioned this pull request Dec 15, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vladfrangu vladfrangu vladfrangu approved these changes

@kyranet kyranet kyranet approved these changes

@SpaceEEC SpaceEEC SpaceEEC approved these changes

@suneettipirneni suneettipirneni suneettipirneni approved these changes

@iCrawl iCrawl Awaiting requested review from iCrawl

Assignees
No one assigned
Labels
documentation packages:discord.js refactor semver:patch
Projects
discord.js
Archived in project
Milestone
discord.js 14.8
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@MrMythicalYT @vladfrangu @kyranet @SpaceEEC @suneettipirneni @Jiralite