feat(WebSocketShard): heartbeat jitter #9223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
github-actions
bot
requested review from
iCrawl,
kyranet,
SpaceEEC and
vladfrangu
Codecov Report
@@ Coverage Diff @@
## main #9223 +/- ##
==========================================
- Coverage 83.74% 83.67% -0.07%
==========================================
Files 100 100
Lines 9546 9552 +6
Branches 1101 1101
==========================================
- Hits 7994 7993 -1
- Misses 1513 1520 +7
Partials 39 39
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
vladfrangu
approved these changes
Mar 12, 2023
kyranet
approved these changes
Mar 12, 2023
SpaceEEC
approved these changes
Mar 12, 2023
darkyeg
reviewed
Mar 15, 2023
| const jitter = Math.random(); | ||
| const firstWait = Math.floor(payload.d.heartbeat_interval * jitter); | ||
| this.debug([`Preparing first heartbeat of the connection with a jitter of ${jitter}; waiting ${firstWait}ms`]); | ||
|
|
There was a problem hiding this comment.
I think it's better that we do it this way so we can clear it if needed because we won't be able to clear the sleep if we need to
this.heartbeatInterval = setInterval(async () => {
if (this.heartbeatInterval) clearInterval(this.heartbeatInterval);
this.heartbeat();
this.heartbeatInterval = setInterval(() => void this.heartbeat(), payload.d.heartbeat_interval);
}, payload.d.heartbeat_interval * Math.random());
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please describe the changes this PR makes and why it should be merged:
Puts us more in line with https://discord.com/developers/docs/topics/gateway#sending-heartbeats - where the impl prior to this PR effectively just meant a hardcoded jitter of
1.Closes #9197
Status and versioning classification: