Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltip to Admin & Moderator glyph #2442

Merged
merged 1 commit into from
Jun 13, 2014

Conversation

arpitjalan
Copy link
Member

Added tooltip to Admin & Moderator glyph (relevant meta topic).

glyph-tooltip

@discoursebot
Copy link

You've signed the CLA, techAPJ. Thank you! This pull request is ready for review.

@coding-horror
Copy link
Contributor

Hmm, do we want to show the user's name here? I think "this user is an admin" would be simpler and avoid tying into the "don't show / hide full names" site setting we have.

@arpitjalan
Copy link
Member Author

Yeah you're right, user's name doesn't make sense here. Also totally forgot about "don't show / hide full names" site setting, which will increase complexity.

Updated the code and screenshot.

@arpitjalan
Copy link
Member Author

Updated as per your feedback @eviltrout.

eviltrout added a commit that referenced this pull request Jun 13, 2014
Add tooltip to Admin & Moderator glyph
@eviltrout eviltrout merged commit 929a195 into discourse:master Jun 13, 2014
@eviltrout
Copy link
Contributor

Thanks

@arpitjalan arpitjalan deleted the add-tooltip-to-glyph branch June 19, 2014 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants