FIX: Onebox instagram links that contain the username profile

discourse · Apr 11, 2019 · 912d579 · 912d579 · discoursebot · Apr 11, 2019
1 parent eba1f3e
commit 912d579
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/lib/onebox/engine/instagram_onebox.rb b/lib/onebox/engine/instagram_onebox.rb
@@ -7,7 +7,7 @@ class InstagramOnebox
       include StandardEmbed
       include LayoutSupport
 
-      matches_regexp(/^https?:\/\/(?:www\.)?(?:instagram\.com|instagr\.am)\/p\//)
+      matches_regexp(/^https?:\/\/(?:www\.)?(?:instagram\.com|instagr\.am)\/[a-zA-Z0-9]+\/p\//)
       always_https
 
       def data

diff --git a/spec/lib/onebox/engine/instagram_onebox_spec.rb b/spec/lib/onebox/engine/instagram_onebox_spec.rb
@@ -19,4 +19,10 @@
   it "includes description" do
     expect(html).to include("1.2m Likes, 6,100 Comments - National Geographic (@natgeo) on Instagram")
   end
+
+  it 'Oneboxes links that include the username' do
+    link_with_profile = 'https://www.instagram.com/bennyblood24/p/Brc6FNRn9vu/'
+    onebox_klass = Onebox::Matcher.new(link_with_profile).oneboxed
+    expect(onebox_klass.name).to eq(described_class.name)
+  end
 end