Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special characters in source text need escaping #16

Closed
dishmint opened this issue Sep 11, 2021 · 3 comments
Closed

Special characters in source text need escaping #16

dishmint opened this issue Sep 11, 2021 · 3 comments
Assignees
Labels
bug Wrong behavior

Comments

@dishmint
Copy link
Owner

dishmint commented Sep 11, 2021

This is a problem... VerbPhrase uses up a lot of memory. I can try it on a small text to see if the same issue occurs. This query should be possible, but the scope of fixing it might be beyond the development of this function.

Screen Shot 2021-09-10 at 10 21 11 PM

@dishmint dishmint added the bug Wrong behavior label Sep 11, 2021
@dishmint dishmint self-assigned this Sep 11, 2021
@dishmint
Copy link
Owner Author

Screen Shot 2021-11-16 at 5 09 32 AM

Got further along this time, but it seems that punctuation characters in the source text are messing with the RegEx, I'll need to escape those characters.

@dishmint dishmint added this to the String and WikipediaSearch milestone Nov 16, 2021
@dishmint dishmint added the P1 label Nov 16, 2021
@dishmint dishmint changed the title Some TextTypes use up Memory Special characters in source text need escaping Nov 16, 2021
@dishmint
Copy link
Owner Author

This has been done, though I'm not sure it resolves the issues above. I think the XPhrase types cause a lot of overhead because the patterns they match are large.

@dishmint
Copy link
Owner Author

Special characters don't seem to be an issue. + since I've removed the use of RegularExpressions I don't suspect the backslash Q and backslash E messages to crop up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Wrong behavior
Projects
Status: Done
Development

No branches or pull requests

1 participant