Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hints on collection members aren't generated #600

Closed
kubukoz opened this issue Nov 12, 2022 · 3 comments · Fixed by #769
Closed

Hints on collection members aren't generated #600

kubukoz opened this issue Nov 12, 2022 · 3 comments · Fixed by #769
Labels
bug Something isn't working

Comments

@kubukoz
Copy link
Member

kubukoz commented Nov 12, 2022

Spawned by #599 (comment).

You can apply some hints on collection members, e.g.:

list Strings {
  @deprecated @documentation("foo") member: String
}

and they don't end up in the generated schema. This should be fixed, so that the collection's schema includes the hints.

Also: check if the dynamic model reads these hints.

@kubukoz kubukoz added the bug Something isn't working label Nov 12, 2022
@kubukoz
Copy link
Member Author

kubukoz commented Nov 17, 2022

bruh I'm literally tripping, I just made #609 which is the exact same thing

@Baccata
Copy link
Contributor

Baccata commented Nov 18, 2022

Did you mean enum members instead of collection members ?

@kubukoz
Copy link
Member Author

kubukoz commented Nov 18, 2022

enum members are done in #599. I meant collection indeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants