Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected status code treatment #4

Closed
n8han opened this issue Mar 19, 2012 · 2 comments
Closed

Unexpected status code treatment #4

n8han opened this issue Mar 19, 2012 · 2 comments

Comments

@n8han
Copy link

n8han commented Mar 19, 2012

We want to default to non-20x status codes being a fatal error, but this behavior should be obvious to the reader and also obvious how to override it.

@n8han
Copy link
Author

n8han commented Mar 20, 2012

We should also anticipate people want to log some portion of the response body when there is an unexpected status. Just the number or an instance of this class is not much context.

@n8han n8han closed this as completed in f2bf0d8 Apr 4, 2012
@n8han
Copy link
Author

n8han commented Apr 4, 2012

I tried adding the handler to the StatusCode class but it wasn't very useful. You have to match against the type of the handler and get it right to do much with it. I think in most cases if people want to handle the non-okay cases they won't use the ok handler, now that it's explicit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant