forked from phacility/phabricator
-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Cut Herald rules off at 1GB of diff text
Summary: Ref T4276. When a change is larger than 2GB, PHP can not read the entire change into a string, so Herald can not process it. Additionally, we already have a time limit for practical reasons, but it's huge (probably incorrectly). To deal with these things: - Add an optional byte limit to `diffusion.rawdiffquery`. - Make the query with a 1GB limit. - Reduce the diff timeout from 15 hours to 15 minutes. - Add a "Changeset is enormous" field. This field is true for changes which are too large to process. This generally makes behaviors more sane: - We'll always make progress in Herald in a reasonable amount of time. - Installs can write global rules to handle (or reject) these types of changes. Test Plan: Set limit to 25 bytes instead of 1GB and ran test console on various changes. Reviewers: btrahan Reviewed By: btrahan CC: aran Maniphest Tasks: T4276 Differential Revision: https://secure.phabricator.com/D7885
- Loading branch information
epriestley
committed
Jan 3, 2014
1 parent
972dfa7
commit 8ddf883
Showing
8 changed files
with
60 additions
and
19 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters