CTD when loading

[Swootch]

Starting a game with PKs Rebalancing causes a CTD during loading:

anothersimulacrum on the discord said it's as easy as deleting the NO_ROTATE flag from the corresponding object, but when I do it, it just causes more errors.

[sdp0et]

I opened this issue in the main CDDA repo: CleverRaven/Cataclysm-DDA#31897

They closed it saying it was due to PK and/or Arcana, which both use the terrain I used as an example "strange_cabin"/"strange_cabin_north". I made some assumptions about what was going on and stepped through each error as it occurred and changed the pk mod files and it seems to work.

@Bulletfang I had to make two types of changes.

for each invalid terrain reference

• See if the terrain is overridden in pk_overmap_terrain.json, if so remove the NO_ROTATE flag (I removed the whole line, not just the flag itself).
• also check in pk_overmap for any references to that terrain id in the overmap_special definitions and append a direction ( chose "_north" because that's what I saw in the core json files, but I really am not sure if it's correct in all cases) ex: "overmap": "campsite_a" to "overmap": "campsite_a_north"

There were a a handful of changes in each file, but not every id references in pk_overmap.json was overridden in in pk_overmap_terrain.json.

I don't know if it "works" but I am at least able to generate a world without a CTD.

[dissociativity]

attempted a fix, I'm not expert though, so let me know how it is now in the latest version from the github zip (not other the releases tab, just download zip, I'm sure you're smart and know this but others have made the mistake of only using the releases tab before)

[dissociativity]

fixed!