Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move from custom logging to SLF4J and Logback #1471

Closed
jelovirt opened this issue Mar 9, 2013 · 1 comment
Closed

Move from custom logging to SLF4J and Logback #1471

jelovirt opened this issue Mar 9, 2013 · 1 comment
Assignees
@jelovirt
Labels
architecture Label is obsolete, do not use feature New feature or request priority/medium Medium (or unknown) priority issue
Milestone
3.0

Comments

@jelovirt
Copy link
Member

jelovirt commented Mar 9, 2013

Replace DITAOTLogger with SLF4J and use Logback as the logging implementation.
@ghost ghost assigned jelovirt Mar 9, 2013
@jelovirt
Copy link
Member Author

jelovirt commented Mar 9, 2013

The following messages use the same parameter multiple times:

  • DOTJ020W
  • DOTX018I
  • DOTX019W
  • DOTX052W

SLF4J uses parameterized message format that doesn't allow this. Options to handle this:

  1. Rewrite messages. For build-in messages this is not a problem, but for custom plug-ins this is a problem. Changing this would be a backwards incompatible change.
  2. Don't use SLF4J's message parameterization, but rather e.g. java.lang.String#format(String, Object[]) or java.text.MessageFormat.

@robander, do you have a preference? My preference is for the former, i.e. remove support for using the same parameter value in messages multiple times. Affected plug-ins would have to pass the same parameter value multiple times.

jelovirt added a commit that referenced this issue Mar 11, 2013
@jelovirt
Clean logging #1471
040aa18 
To make transition to other logging frameworks easier, reactor logging:

* Remove support for Properties as message arguments
* Replace logException with logError
* Remove logFatal and logException
jelovirt added a commit that referenced this issue Jan 20, 2014
@jelovirt
Rename logging methods to match common logging frameworks #1471
ef77d71
@jelovirt jelovirt modified the milestones: 2.0, 2.1 Nov 18, 2014
@jelovirt jelovirt modified the milestones: 2.1, 2.2 Jun 8, 2015
@jelovirt jelovirt modified the milestones: 3.0, 2.2 Oct 22, 2015
@jelovirt jelovirt modified the milestones: 2.4, 3.0 Nov 5, 2016
jelovirt added a commit that referenced this issue Jul 6, 2017
@jelovirt
Make DITAOTLogger extend SLF4J Logger #1471
9ed3abf
jelovirt added a commit that referenced this issue Jul 6, 2017
@jelovirt
Add messages resource bundle generation #1471
8629552
jelovirt added a commit that referenced this issue Jul 6, 2017
@jelovirt
Refactor logging #1471
7a4e3cf
@jelovirt jelovirt closed this as completed Jul 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jelovirt jelovirt

Labels
architecture Label is obsolete, do not use feature New feature or request priority/medium Medium (or unknown) priority issue
Projects
None yet
Milestone
3.0
Development

No branches or pull requests
1 participant
@jelovirt