This repository has been archived by the owner on Nov 4, 2024. It is now read-only.

refactor(sdk): Expose the models package #21

Merged

ditsuke merged 1 commit into main from refactor/models

Jan 14, 2023

Member

ditsuke commented Jan 14, 2023

What

Exposes models package (move from the internal sub-package to root amizone).

Why

The re-export pattern doesn't work with Go (types can't retain associated
functions)
Less redundant code
Less complexity
Future models and tests will be simpler to add.

ditsuke force-pushed the refactor/models branch 2 times, most recently from be52057 to 54d8e80 Compare

January 14, 2023 09:12


          refactor: export the models package

5e4a751

Since Go's re-export pattern is broken (re-exported types
can't retain their associated function's), this commit:
- Removes the re-export layer
- Moves the models package from the `internal` package
  to the base amizone package.

Implications are easier handling of new models, less
duplicated code and logic etc.

ditsuke force-pushed the refactor/models branch from 54d8e80 to 5e4a751 Compare

January 14, 2023 09:16

sonarcloud bot commented Jan 14, 2023

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

ditsuke merged commit 775750b into main

ditsuke deleted the refactor/models branch

January 14, 2023 09:21

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet