This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
refactor(api-server): Decouple the server and the server command #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- This interface makes it easier to decouple consumers of the client from the concrete amizoneClient interface, making it easier to test through DI without consumers having to define their own types. - Interface compliance constraints are moved to the interface file true to Go's spirit of implementors not coupled with interface definitions.
With this commit, the server and the command are decoupled. The command now rests in the conventional /cmd/<command-name> location. The new server architecture opens up the possibility of better testing, too, with the use of the `amizone.ClientFactoryInterface` for the authentication handler layer.
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
With this PR, the server and the command are decoupled. The command now rests in the conventional
/cmd/<command-name>location. The new server architecture opens up the possibility of better testing, too,with the use of the new
amizone.ClientFactoryInterfacefor the authentication handler layer.