87 decouple configuration from the core it does require to analyze how this is working #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ultiple configuration formats
…still lacks the call to the metamodel with the configuration parser
…ic new metamodel provided with the core and with the possibility to be extended. Also, we can now use the command result = dm.use_operation_from_file('ValidConfiguration', './allrelationships.xml',None, configuration_file='./empty.csvconf') # This launch the operation and stores the result on the result variable
…uration-from-the-core-it-does-require-to-analyze-how-this-is-working
Virako
added a commit
that referenced
this pull request
Jun 22, 2022
… how this is working (#88) Close 87 * removing bad implementation of the configurations that do not allow multiple configuration formats * partial commit that solves the configuration issue with elegance. It still lacks the call to the metamodel with the configuration parser * Solving the issue with configurations, now, it Configuration is a basic new metamodel provided with the core and with the possibility to be extended. Also, we can now use the command result = dm.use_operation_from_file('ValidConfiguration', './allrelationships.xml',None, configuration_file='./empty.csvconf') # This launch the operation and stores the result on the result variable Co-authored-by: Víctor Ramírez de la Corte <virako.9@gmail.com>
jagalindo
deleted the
87-decouple-configuration-from-the-core-it-does-require-to-analyze-how-this-is-working
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm pr this that allows the use of something like this
from famapy.core.discover import DiscoverMetamodels # This loads the tool in the python execution environment
dm = DiscoverMetamodels() # Instantiate the class
result = dm.use_operation_from_file('ValidConfiguration', './allrelationships.xml',None, configuration_file='./empty.csvconf') # This launch the operation and stores the result on the result variable
and avoids the fixation of file names. Sadly it affects all other plugins. I'll be pr'ing on their repos
Please, @Virako take a look to see if everything is correct. Is basically a new embedded plugin that allows the reading of configurations