Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: support parsing "git://" remote URI to Github URL #614

Merged
merged 1 commit into from
Mar 5, 2017

Conversation

asfaltboy
Copy link
Member

This commit also logs an error in case parsing fails.

Fix #612

This commit also logs an error in case parsing fails.

Fix timbrel#612
Copy link
Member

@stoivo stoivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@divmain
Copy link
Collaborator

divmain commented Mar 5, 2017

That's a great catch. Thanks @asfaltboy!

@divmain divmain merged commit eb70249 into timbrel:master Mar 5, 2017
@asfaltboy asfaltboy deleted the feature/github-parse-url-fix branch March 5, 2017 01:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants