Improve: Remove some clutter from debug.log #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
randy3k
reviewed
Apr 28, 2017
core/git_command.py
Outdated
| @@ -72,7 +72,8 @@ def git(self, *args, | |||
| decode=True, | |||
| encode=True, | |||
| stdin_encoding="UTF-8", | |||
| custom_environ=None): | |||
| custom_environ=None, | |||
| skip_adding_to_log=False): | |||
There was a problem hiding this comment.
it seems to me that it overkills. Maybe something like this (untested)?
from contextlib import contextmanager
@contextmanager
def disable_logging():
util.debug.stop_logging()
try:
yield
finally:
util.debug.start_logging()
with disable_logging():
short_status = self.get_branch_status_short()There was a problem hiding this comment.
start_logging() is resetting the log.
but it looks better
|
@randy3k, I did't know of contextmanager. This is so much cleaner 🎉 |
randy3k
reviewed
Apr 28, 2017
core/commands/status_bar.py
Outdated
| @@ -57,7 +58,8 @@ def run_async(self): | |||
| self.view.erase_status("gitsavvy-repo-status") | |||
| return | |||
|
|
|||
| short_status = self.get_branch_status_short() | |||
| with disable_logging(): | |||
randy3k
approved these changes
Apr 28, 2017
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not super nice but I prefer to have setting as arguments instead of state on an object.