Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhancement: do not open panel when window doesn't exist #746

Merged
merged 1 commit into from
Aug 21, 2017
Merged

Enhancement: do not open panel when window doesn't exist #746

merged 1 commit into from
Aug 21, 2017

Conversation

randy3k
Copy link
Collaborator

@randy3k randy3k commented Aug 21, 2017

Another enhancement of issue #726.

Throw RuntimeError If the current view is detached, it will result in a GitSavvyError without showing panel.

cc: @asfaltboy, hope this would be the final fix.


The maintainers of this repo require that all pull request submitters agree and adhere to the following:

  • I have read and agree to the contribution guidelines.
    (required)
  • All related documentation has been updated to reflect the changes made. (required)
  • My commit messages are cleaned up and ready to merge. (required)

The maintainers of this repository require you to select the semantic version type that
the changes in this pull request represent. Please select one of the following:

  • major
  • minor
  • patch
  • documentation only

@maintainerd
Copy link

maintainerd bot commented Aug 21, 2017

maintainerd logging is enabled for this repository.

All actions related to rules and their enforcement will be logged here as a permanent record.


Click to view log...

  • 2017-08-21T01:20:05.201Z:bf0ae11: The pull request was created
  • 2017-08-21T01:20:20.302Z:bf0ae11: @randy3k checked I have read and agree to the [contribution guidelines](https://github.com/divmain/GitSavvy/blob/master/CONTRIBUTING.md)..
  • 2017-08-21T01:20:21.614Z:bf0ae11: @randy3k checked My commit messages are cleaned up and ready to merge. _(required)_.
  • 2017-08-21T01:20:23.942Z:bf0ae11: @randy3k selected patch as the semantic version.

@randy3k randy3k requested a review from asfaltboy August 21, 2017 01:20
@stoivo stoivo merged commit fc407fc into timbrel:master Aug 21, 2017
@randy3k randy3k deleted the git_command branch August 21, 2017 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants