Skip to content
This repository has been archived by the owner on Jan 30, 2021. It is now read-only.

Put npm install inside start.sh #6

Closed
divmain opened this issue Oct 29, 2014 · 4 comments
Closed

Put npm install inside start.sh #6

divmain opened this issue Oct 29, 2014 · 4 comments

Comments

@divmain
Copy link
Owner

divmain commented Oct 29, 2014

No description provided.

@baer
Copy link
Collaborator

baer commented Nov 5, 2014

If you're going to advertise "clone and go" start probably shouldn't do that.

@divmain
Copy link
Owner Author

divmain commented Nov 6, 2014

Can you expand on that? It seems like a user will always be doing start.sh and then npm install, I'm trying to think of cases where npm install isn't the next step.

@baer
Copy link
Collaborator

baer commented Nov 6, 2014

Maybe I just don't see the overall vision for start.sh. As it is now it's just a small set of completely optional project bootstrapping utilities that take care of some of the annoying things that are a part of starting a new project but not a part of a typical workflow.

I'd argue that npm install is a part of a normal workflow for any project seed or otherwise and therefore doesn't belong in start.sh.

$ git clone <project uri>
$ cd <project-name>
$ npm install
$ npm start

That said, calling npm install a second time (if you're used to it) will just noop so there isn't any harm in doing it.

@divmain
Copy link
Owner Author

divmain commented Nov 7, 2014

That seems like a reasonable argument. I'll close this and revisit if I think of a good reason to.

@divmain divmain closed this as completed Nov 7, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants