Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Discrete Fourier transform" is better known as "Number theoretic transform" #632

Open
cjpatton opened this issue Jul 3, 2023 · 1 comment

Comments

@cjpatton
Copy link
Collaborator

cjpatton commented Jul 3, 2023

Most crypto libraries use "NTT" instead of "FFT".

@divergentdave
Copy link
Contributor

Real World Crypto has got me energized to make this change, but I think it ought to wait for the next time we bump the minor version. My two big backwards compatibility concerns are FlpError::Fft (there's no way to get around the possibility that consumers may be using this enum variant) and FieldElementFftFriendly (we could perhaps have two traits, with a blanket impl linking them, but that introduces concerns about ambiguous method resolution).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants