Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Branch protection on gh-pages doesn't include administrators #6

Closed
inahga opened this issue Sep 7, 2023 · 2 comments
Closed

Branch protection on gh-pages doesn't include administrators #6

inahga opened this issue Sep 7, 2023 · 2 comments
Assignees
@inahga

Comments

@inahga
Copy link
Collaborator

inahga commented Sep 7, 2023

Admins can bypass the branch protection rules on gh-pages, which allows for accidental direct pushes to that branch. We can't enable bypass protection because deployment happens through deploy key, which acts as an administrator.

The root of the problem is that GitHub has poor support for making GitHub Actions-only branches. See https://github.com/orgs/community/discussions/13836. There are some workarounds available, such as using a GitHub App or bot-only account for deploys and allowing it to bypass protection.
@inahga
Copy link
Collaborator Author

inahga commented Jul 16, 2024

This might be fixable with rulesets...

@inahga inahga self-assigned this Jul 16, 2024
@inahga
Copy link
Collaborator Author

inahga commented Jul 17, 2024

I was able to fix this using rulesets.

@inahga inahga closed this as completed Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inahga inahga

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@inahga