Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal dbus version? #44

Closed
djc opened this issue May 26, 2016 · 4 comments
Closed

Minimal dbus version? #44

djc opened this issue May 26, 2016 · 4 comments

Comments

@djc
Copy link

djc commented May 26, 2016

I was trying to compile Servo in a CentOS 6.5 environment, which has dbus-1.2.24-7. Linking fails:

/home/djc/src/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/dbus-0.3.3/src/strings.rs:28: error: undefined reference to 'dbus_validate_path'
/home/djc/src/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/dbus-0.3.3/src/strings.rs:19: error: undefined reference to 'dbus_validate_path'
/home/djc/src/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/dbus-0.3.3/src/strings.rs:28: error: undefined reference to 'dbus_validate_member'
/home/djc/src/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/dbus-0.3.3/src/strings.rs:19: error: undefined reference to 'dbus_validate_member'
/home/djc/src/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/dbus-0.3.3/src/strings.rs:28: error: undefined reference to 'dbus_validate_interface'
/home/djc/src/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/dbus-0.3.3/src/strings.rs:19: error: undefined reference to 'dbus_validate_interface'
/home/djc/src/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/dbus-0.3.3/src/strings.rs:28: error: undefined reference to 'dbus_validate_bus_name'
/home/djc/src/servo/.cargo/registry/src/github.com-1ecc6299db9ec823/dbus-0.3.3/src/strings.rs:19: error: undefined reference to 'dbus_validate_bus_name'

What versions of dbus are supported? Would it be viable to support this version of dbus?

@diwic
Copy link
Owner

diwic commented May 26, 2016

Oh, so my library made it into Servo, cool :-)

What versions of dbus are supported?

No idea, really, since D-Bus only has online documentation for its latest version, I have no idea when various functions were added. Sorry.

Would it be viable to support this version of dbus?

If those are the only functions I need to remove, then I guess I could add some feature that opts out of them? With the drawback that validation will always succeed and potentially things would panic at a later point rather than return a proper error. Would that be a reasonable solution?

@djc
Copy link
Author

djc commented May 29, 2016

I really don't know if that would be a reasonable solution. For the thing I'm trying to build with Servo, I probably don't need dbus anyway, so maybe they should grow a feature to allow for disabling this part.

@diwic
Copy link
Owner

diwic commented Aug 2, 2016

According to DBus's NEWS file, these functions were added in 1.5.12, which makes 1.6.0 the first supported release.

@diwic
Copy link
Owner

diwic commented Mar 17, 2017

@djc You might be interested in that the latest version of dbus now has a "no-strings-validation" feature that should enable you to use it on older dbus library version (although I don't know how far back).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants