Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Watch handling is unsound #99

Closed
diwic opened this issue Aug 24, 2017 · 0 comments
Closed

Watch handling is unsound #99

diwic opened this issue Aug 24, 2017 · 0 comments

Comments

@diwic
Copy link
Owner

diwic commented Aug 24, 2017

The good news: Removing and adding watches is very rare and happens only during special conditions, e g while keeping Messages with a total length of > 63 MB in memory.

The bad news: This is not easily fixable, probably requires a rethink and a 0.6 release to get right.

The problems are (as more thoroughly explained by @albel727 in #72 ):

  • When removing/disabling a watch, we need to process it immediately because DBus might close the fd immediately after the callback ends
  • When adding/enabling a watch, we get a callback, but it can come from a separate thread, because calling dbus_message_unref can trigger it (and we have a impl Send for Message).
@diwic diwic mentioned this issue Aug 24, 2017
@diwic diwic closed this as completed in aededc4 Nov 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant