Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mod.select should also select dependencies #25

Closed
LiaungYip opened this issue Mar 30, 2018 · 3 comments
Closed

mod.select should also select dependencies #25

LiaungYip opened this issue Mar 30, 2018 · 3 comments

Comments

@LiaungYip
Copy link

LiaungYip commented Mar 30, 2018

For example:

Storage Drawers Extras has two required dependencies:

  1. Chameleon
  2. Storage Drawers

These should be selected at the same time Storage Drawers Extras is selected.

Recursive selection: Selection of dependencies should be recursive, if required.

Dependencies not satisfied: If a dependency could not be satisfied, the entire operation should fail and no changes should be committed. Dependencies might fail if, for example, a dependency is not available for the current version of Minecraft.


This would require the database to contain information on the dependencies of each mod. This information is exposed on the Relations > Dependencies pages for each mod. Example: Storage Drawers > Relations > Dependencies.

The crawler code doesn't appear to be public, so I can't assist with the crawler. (I have something hacky written in Python / BeautifulSoup to satisfy my immediate requirements.)

@LiaungYip
Copy link
Author

The plot thickens: dependencies are per-file, not per project.

See: Chisel-Team/Chisel#669 .

So the database would also need to capture dependencies per file.

@dizzyd
Copy link
Owner

dizzyd commented Sep 18, 2018

Resolved in latest release; let me know how it works. :)

@dizzyd dizzyd closed this as completed Sep 18, 2018
@LiaungYip
Copy link
Author

This feature works really well!

(To the extent that CurseForge authors correctly record their dependencies; but that's an upstream issue.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants