Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add snapcraft #105

Merged
merged 4 commits into from
Dec 7, 2017
Merged

Add snapcraft #105

merged 4 commits into from
Dec 7, 2017

Conversation

daniellimws
Copy link
Contributor

With this, users can easily install and update via the snap store, by doing sudo snap install hightail.

With this, users can easily install and update via the snap store,
by doing `sudo snap install hightail`
@dj3500
Copy link
Owner

dj3500 commented Dec 4, 2017

If I pull this in, that's it? Running that command will always clone the current master from github and compile it? Or would I need to register hightail on snap's website (whatever that is)?

@daniellimws
Copy link
Contributor Author

Currently I've registered hightail on the snap store, but it's bound to my account, not sure if that's a problem.

As you can see here, snapcraft can build the project every time an update is made, and release it to the snap store. (I think it should be automatic)

However I think since updates are all made to the main repository (which is this one), you'll have to register an account and add your repo for it to work. Or alternatively I'll pull the updates from your repo, and it should work fine.

Problem is although this is somewhat slightly better for deployment, I believe downloading the file straight from the releases page would be faster because snap may add some metadata (i'm not too sure about that).

tldr: if you are lazy, probably just ignore this pull request

These unnecessary dependencies caused the release on snap store to fail.
Removing them should fix the problem.
@dj3500
Copy link
Owner

dj3500 commented Dec 6, 2017

Hmm. So I am indeed too lazy if I would have to do something every time master gets an update. On the other hand, if it's about doing some stuff now and being able to forget about it, then I'm up for it :)

And also, it is master, right? Or only the GitHub releases? And the version string should not be v0.9.6, I think - right now that's the latest release, but master is ahead of that, and also we're not going to update this string every time something changes. Maybe we can leave the version empty...

So what do I do?

@daniellimws
Copy link
Contributor Author

Yeah it's a one-time setup. You just need to merge my pull request as I've got every thing setup properly in there already. Then, register an account at build.snapcraft.io/.

However one problem is I've registered the name hightail so you may have problems registering that name with your account. I'll try to get that name unregistered at the meantime.

@come-maiz
Copy link

Hey @dj3500, once you fill the registration form in https://dashboard.snapcraft.io you can add a comment to request the transfer of the name from @daniellim2000. Give it a try, the snap will be built and released automatically from https://build.snapcraft.io every time you change master. The snap will land in the edge channel, where your community and the community of ubuntu testers can give it a try and provide quick feedback. And once you are confident with a version and move it to the stable channel, it will be exposed to millions of users from the store, who can install it with one click/command, and get automatic updates.

About the version string, you can use version: git, and when you add an annotated tag to the repo to make a release, the version of the snap will take the value of the tag. But you can worry about the details later as you go, the edge channel is for experimentation. If you and your users like it, you can then maintain the stable release.

Thanks @daniellim2000 !

@daniellimws
Copy link
Contributor Author

Thanks for the help @ElOpio .

@dj3500 dj3500 merged commit 868015d into dj3500:master Dec 7, 2017
@dj3500
Copy link
Owner

dj3500 commented Dec 7, 2017

Ok, I made a petition and merged this in. Also pushed a commit to change the version string to git.

Please let me know when it works - I don't have a Linux machine to test this on. Also, I think we can put it on the stable channel from the get go...

@daniellimws
Copy link
Contributor Author

Alright great.

@dj3500
Copy link
Owner

dj3500 commented Dec 7, 2017

Should I also add the repo (the bit that does OAuth from GitHub etc.)? Right now I just made an account and requested rights to the hightail snap...

@dj3500
Copy link
Owner

dj3500 commented Dec 7, 2017

Alright, I added, it got released. Could one of you guys test: sudo snap install --edge hightail?
In particular, it would be good to see if hightail.config survives between sessions (i.e., whether hightail has write access to that).

And another question to the snap afficionados. If I release this version (1) as stable, that doesn't imply that any future (automatic) releases to edge will be in stable, right? Is there a way to make all new commits to master here create a new stable release? If not, I suppose I will just stay on edge forever. (But are there automatic updates then? If someone installed via install --edge, do they get the edge updates forever?)

@daniellimws
Copy link
Contributor Author

@dj3500
Ok, I'll test it out in the next few codeforces rounds.

@dj3500
Copy link
Owner

dj3500 commented Dec 7, 2017 via email

@daniellimws
Copy link
Contributor Author

@dj3500 Hey I just checked. Settings is preserved.

@daniellimws daniellimws deleted the add-snapcraft branch December 13, 2017 18:36
@dj3500
Copy link
Owner

dj3500 commented Jul 12, 2018

I've been getting the following emails:

====================
A scan of this snap shows that it was built with packages from the Ubuntu
archive that have since received security updates. The following lists new USNs
for affected binary packages in each snap revision:

Revision r19 (i386; channels: edge)

  • libcups2: 3713-1
  • libpng12-0: 3712-1

Revision r20 (amd64; channels: edge)

  • libcups2: 3713-1
  • libpng12-0: 3712-1

Revision r21 (armhf; channels: edge)

  • libcups2: 3713-1
  • libpng12-0: 3712-1

Simply rebuilding the snap will pull in the new security updates and resolve
this. If your snap also contains vendored code, now might be a good time to
review it for any needed updates.

Thank you for your snap and for attending to this matter.

References:

When I received this about the previously latest commit, I made a trivial commit to the repo to make the snap rebuild, but now I got this again. How to fix this?

@daniellimws
Copy link
Contributor Author

Hey there, the emails you received may have been referring to different packages, so there were a few. But you should only get one email per security update.

So you should just trigger a rebuild again and it should be fine.

@dj3500
Copy link
Owner

dj3500 commented Nov 17, 2018

Hi Daniel, could you please take a look at issue #110 and check whether it's buggy now, or advise the person somehow?

@daniellimws
Copy link
Contributor Author

Hi, I'm busy until the end of the month. Would it be fine if I look into this after that?

@dj3500
Copy link
Owner

dj3500 commented Nov 22, 2018

Sure.

@dj3500
Copy link
Owner

dj3500 commented Dec 3, 2018

Ping, then ;)

@daniellimws
Copy link
Contributor Author

Not sure what updates there were for snapcraft that caused the original snapcraft.yaml to not work. I'm working on it but have yet to succeed.

@dj3500
Copy link
Owner

dj3500 commented Dec 19, 2018

Ping again?

@dj3500
Copy link
Owner

dj3500 commented Apr 18, 2019

Let me ping this :)

@daniellimws
Copy link
Contributor Author

Hi sorry actually I've not done any snap related stuff for over a year. The last time I tried it seems like things have changed that I'm unsure of. I think it's better to ask in the snapcraft forums to check with the snapcraft developers. I can do that if you want.

@dj3500
Copy link
Owner

dj3500 commented Jul 5, 2019

Hmm, would be nice if you could. I think currently it still doesn't work (i.e. didn't fix itself :) ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants