Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactorizations, fixes #44, #35, #34, #25 #45

Merged
merged 7 commits into from
May 20, 2013

Conversation

Krigpl
Copy link
Contributor

@Krigpl Krigpl commented May 18, 2013

Refactorization of keyboard shortcuts: all shortcuts are now in separate class.
Refactorization of parsers: adding a new task/contest parser should be neater now.
Refactorization of execution results: chenged execution results to Enum. Adding new execution result requires less code now.
#25: All windows appear in the center of previous window.
#34: Right click on the problem tab and the option "delete" will appear.
#35: There are two abort buttons now: abort current test and abort all tests. Both work fine.
#44: Copy input button added. With shortcut ctrl+shift+c.

Other changes:

  • Time limit is now editable. And task parser for Codeforces extract and set time limit for all tests.
  • alt+[1-9] switches between problems.
  • Added tool tip to parsing result label. Moving cursor over "parsing failed" shows message with exact parsing error.

@dj3500
Copy link
Owner

dj3500 commented May 19, 2013

This is looking really great!
Just a few things:

  1. aborting tests doesn't work for me (with a program "int main () { while(1); }", "abort current test" does nothing, and "abort all tests" does nothing to the current test but prevents further ones from running after the current one TLEs
  2. in "new problem" dialog, if user set their own problem name and then pasted the URL and clicked "Parse", the name should not get overwritten by the parser
  3. what does "NOT18N" mean?

@Krigpl
Copy link
Contributor Author

Krigpl commented May 19, 2013

  1. Fixed. That was stupid bug and my tests were weird that they did not detected this.
  2. Fixed.
  3. I don't know. Netbeans auto-generated that at some point, don't know why.

@dj3500
Copy link
Owner

dj3500 commented May 20, 2013

In 2: When I set my own name and then parse (or first parse and then set own name), my name stays in the "Name" textfield but is still overwritten in the actual name of the tab that gets created.

…Krigpl/hightail into refactorizations_and_many_fixes

Conflicts:
	Hightail/src/org/hightail/Testcase.java
@Krigpl
Copy link
Contributor Author

Krigpl commented May 20, 2013

Fixed. Sorry about that.

@dj3500
Copy link
Owner

dj3500 commented May 20, 2013

Awesome!

dj3500 added a commit that referenced this pull request May 20, 2013
@dj3500 dj3500 merged commit 8d06aaa into dj3500:master May 20, 2013
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants