fix: lint menus app (#7534)

* feat: add support for testing menus with ruff as well

* fix: autofix issues with ruff

.github/workflows/linters.yml

@@ -23,4 +23,6 @@ jobs:
           python -m pip install --upgrade pip
           pip install ruff
       - name: Run Ruff
-        run: ruff cms
+        run: |
+          ruff cms
+          ruff menus

menus/menu_pool.py

@@ -8,15 +8,13 @@
 from django.urls import NoReverseMatch
 from django.utils.functional import cached_property
 from django.utils.module_loading import autodiscover_modules
-from django.utils.translation import get_language_from_request, gettext_lazy as _
+from django.utils.translation import get_language_from_request
+from django.utils.translation import gettext_lazy as _
+
 from cms.utils import get_current_site
-from cms.utils.i18n import (
-    get_default_language_for_site,
-    is_language_prefix_patterns_used
-)
 from cms.utils.conf import get_cms_setting
+from cms.utils.i18n import get_default_language_for_site, is_language_prefix_patterns_used
 from cms.utils.moderator import use_draft
-
 from menus.base import Menu
 from menus.exceptions import NamespaceAlreadyRegistered
 from menus.models import CacheKey

menus/templatetags/menu_tags.py

@@ -1,26 +1,23 @@
 from urllib.parse import unquote
 
+from classytags.arguments import Argument, IntegerArgument, StringArgument
+from classytags.core import Options
+from classytags.helpers import InclusionTag
 from django import template
 from django.contrib.sites.models import Site
-from django.urls import reverse, NoReverseMatch
+from django.urls import NoReverseMatch, reverse
 from django.utils.encoding import force_str
 from django.utils.translation import get_language, gettext
 
-from classytags.arguments import IntegerArgument, Argument, StringArgument
-from classytags.core import Options
-from classytags.helpers import InclusionTag
-
 from cms.utils.i18n import (
     force_language,
     get_language_list,
     get_language_object,
     get_public_languages,
 )
-
 from menus.menu_pool import menu_pool
 from menus.utils import DefaultLanguageChanger
 
-
 register = template.Library()
 
 
@@ -379,7 +376,7 @@ def get_context(self, context, template, i18n_mode):
             i18n_mode = _tmp
         if template is NOT_PROVIDED:
             template = "menu/language_chooser.html"
-        if not i18n_mode in MARKERS:
+        if i18n_mode not in MARKERS:
             i18n_mode = 'raw'
         if 'request' not in context:
             # If there's an exception (500), default context_processors may not be called.

menus/utils.py

@@ -1,5 +1,5 @@
 from django.conf import settings
-from django.urls import NoReverseMatch, reverse, resolve, Resolver404
+from django.urls import NoReverseMatch, Resolver404, resolve, reverse
 
 from cms.utils import get_current_site, get_language_from_request
 from cms.utils.i18n import (