Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 4646 refactor details view #5954

Open
wants to merge 27 commits into
base: develop
Choose a base branch
from
Open

Issue 4646 refactor details view #5954

wants to merge 27 commits into from

Commits on Apr 28, 2017

  1. django-cms#4646 deliver pages with a class based view

    @philippze
    philippze committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    b981a04 View commit details
    Browse the repository at this point in the history

  2. django-cms#4646 separate methods fetching page from cache or database

    @philippze
    philippze committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    e45bf56 View commit details
    Browse the repository at this point in the history

  3. django-cms#4646 get current language in separate method

    @philippze
    philippze committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    c6fc4ba View commit details
    Browse the repository at this point in the history

  4. django-cms#4646 try&error pattern for returning not-normal pages

    @philippze
    philippze committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    83dee0c View commit details
    Browse the repository at this point in the history

  5. django-cms#4646 remove duplicate code

    @philippze
    philippze committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    a9a1b6f View commit details
    Browse the repository at this point in the history

  6. django-cms#4646 encapsulate ugly language redirect code in its own fu… 

    …nction
    @philippze
    philippze committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    90f6989 View commit details
    Browse the repository at this point in the history

  7. django-cms#4646 the page_from_database method

    @philippze
    philippze committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    56bd96b View commit details
    Browse the repository at this point in the history

  8. django-cms#4646 use instance variables instead method arguments

    @philippze
    philippze committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    8de8f82 View commit details
    Browse the repository at this point in the history

  9. django-cms#4646 improve method names

    @philippze
    philippze committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    53e222e View commit details
    Browse the repository at this point in the history

  10. django-cms#4646 condense page_from_database method

    @philippze
    philippze committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    86f1a35 View commit details
    Browse the repository at this point in the history

  11. django-cms#4646 DRY treatment of cms redirects

    @philippze
    philippze committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    6aa5fb7 View commit details
    Browse the repository at this point in the history

  12. django-cms#4646 rename exception: NothingToDo -> NoHttpResponseReturned

    @philippze
    philippze committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    0b92b1d View commit details
    Browse the repository at this point in the history

  13. django-cms#4646 always check for circular redirects. This simplifies … 

    …code & needs minimal resources.
    @philippze
    philippze committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    5ea07c2 View commit details
    Browse the repository at this point in the history

  14. django-cms#4646 separate function for completing url with language pr… 

    …efix
    @philippze
    philippze committed Apr 28, 2017
    Configuration menu
    Copy the full SHA
    cfe33ba View commit details
    Browse the repository at this point in the history

Commits on Apr 29, 2017

  1. django-cms#4646 refactor apphook response delivery

    @philippze
    philippze committed Apr 29, 2017
    Configuration menu
    Copy the full SHA
    ee95915 View commit details
    Browse the repository at this point in the history

  2. django-cms#4646 refactor redirect to login

    @philippze
    philippze committed Apr 29, 2017
    Configuration menu
    Copy the full SHA
    abd62bf View commit details
    Browse the repository at this point in the history

  3. django-cms#4646 prefer test for none over exceptions in response atte… 

    …mpts
    @philippze
    philippze committed Apr 29, 2017
    Configuration menu
    Copy the full SHA
    0c7fb6e View commit details
    Browse the repository at this point in the history

  4. django-cms#4646 handle redirections to another language in one single… 

    … place
    @philippze
    philippze committed Apr 29, 2017
    Configuration menu
    Copy the full SHA
    ef44d0a View commit details
    Browse the repository at this point in the history

  5. django-cms#4646 replace comment with meaningfully labelled function

    @philippze
    philippze committed Apr 29, 2017
    Configuration menu
    Copy the full SHA
    177bd39 View commit details
    Browse the repository at this point in the history

  6. django-cms#4646 determine visible languages in i18n utils

    @philippze
    philippze committed Apr 29, 2017
    Configuration menu
    Copy the full SHA
    532134e View commit details
    Browse the repository at this point in the history

  7. django-cms#4646 separate methods handling the two kinds of language r… 

    …edirects
    @philippze
    philippze committed Apr 29, 2017
    Configuration menu
    Copy the full SHA
    64647c8 View commit details
    Browse the repository at this point in the history

  8. django-cms#4646 refactor fallback language treatment

    @philippze
    philippze committed Apr 29, 2017
    Configuration menu
    Copy the full SHA
    291b7eb View commit details
    Browse the repository at this point in the history

Commits on Apr 30, 2017

  1. django-cms#4646 comment prompting to remove ugly method dedirect_root… 

    …_url_if_appropriate
    @philippze
    philippze committed Apr 30, 2017
    Configuration menu
    Copy the full SHA
    30617f1 View commit details
    Browse the repository at this point in the history

  2. django-cms#4646 readability improvements concerning fallback languages

    @philippze
    philippze committed Apr 30, 2017
    Configuration menu
    Copy the full SHA
    c79b0f8 View commit details
    Browse the repository at this point in the history

  3. django-cms#4646 may little readability improvements

    @philippze
    philippze committed Apr 30, 2017
    Configuration menu
    Copy the full SHA
    a044b3a View commit details
    Browse the repository at this point in the history

  4. django-cms#4646 reorder methods

    @philippze
    philippze committed Apr 30, 2017
    Configuration menu
    Copy the full SHA
    79ddefc View commit details
    Browse the repository at this point in the history

  5. django-cms#4646 another comment promting to remove code

    @philippze
    philippze committed Apr 30, 2017
    Configuration menu
    Copy the full SHA
    10b7440 View commit details
    Browse the repository at this point in the history