Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow retrieving page attributes from other sites #6674

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

feat: allow retrieving page attributes from other sites #6674

wants to merge 7 commits into from

Conversation

ianare
Copy link

@ianare ianare commented Apr 26, 2019

Summary

Allow the retrieval of page attributes from other sites.

Proposed changes in this pull request

When running a multi sub-domain site, it's often useful to get the page_attributes from other sites, for example in the footer or header.

Documentation checklist

  • I have updated CHANGELOG.txt if appropriate
  • I have updated the release notes document if appropriate, with:
    • general notes
    • bug-fixes
    • improvements/new features
    • backwards-incompatible changes
    • required upgrade steps
    • names of contributors
  • I have updated other documentation
  • I have added my name to the AUTHORS file
  • This PR's documentation has been approved by Daniele Procida

@ianare ianare force-pushed the wip_page-attributes-for-site branch from f0d0056 to af36940 Compare April 26, 2019 11:58
@coveralls
Copy link

coveralls commented Apr 26, 2019 •
edited

Coverage Status

Coverage remained the same at 78.215% when pulling af36940 on high-testing:wip_page-attributes-for-site into eeb1e47 on divio:develop.

ianare pushed a commit to high-testing/django-cms that referenced this pull request May 2, 2019
backport django-cms#6674
b91135e
@FinalAngel
Copy link
Member

@yakky or @czpython would love to hear your feedback on this. If viable we can schedule it for the next release.

@FinalAngel FinalAngel added this to the 3.8.x milestone Aug 6, 2019
@yakky
Copy link
Member

yakky commented Aug 6, 2019

I think it can be useful, but probably we would need a test for it. I also see test failures, IDK if by changes this PR or pre-existing (and now fixed)

@czpython
Copy link
Contributor

czpython commented Aug 6, 2019

Agree with @yakky, would need a test for this.

@FinalAngel
Copy link
Member

Thanks for the quick feedback. @ianare thank you for the contribution. Would you be able to provide tests for it as mentioned above? It would also be great to get a changelog entry 👍

@ianare
Copy link
Author

ianare commented Aug 6, 2019

Nice! I had looked into tests initially but could not find anything testing these functions. Maybe I missed them, if so where should I look? Otherwise where should the tests live? Thanks

@FinalAngel
Copy link
Member

@ianare the tests can be found in cms/tests, see also:
http://docs.django-cms.org/en/latest/contributing/testing.html

and
http://docs.django-cms.org/en/latest/how_to/contributing.html#how-to-write-a-test

@FinalAngel FinalAngel self-assigned this Aug 6, 2019
@yakky yakky self-assigned this Sep 25, 2020
yakky
yakky requested changes Sep 26, 2020
View reviewed changes
Copy link
Member

@yakky yakky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is a nice addition and implementation looks good

We definitely need a test for this and a changelog entry

@yakky
Copy link
Member

yakky commented Sep 26, 2020

@ianare please let me know if you need any support to handle the requested changes

@vinitkumar vinitkumar mentioned this pull request May 13, 2021
Closed
@goutnet goutnet modified the milestones: 3.9.0, 3.9.x May 18, 2021
@fsbraun fsbraun changed the title allow retrieving page attributes from other sites feat: allow retrieving page attributes from other sites Apr 25, 2023
github-advanced-security[bot]
github-advanced-security bot found potential problems Apr 25, 2023
View reviewed changes
cms/templatetags/cms_tags.py
@@ -395,13 +396,13 @@
"changed_by",
]

def get_value(self, context, name, page_lookup):
def get_value(self, context, name, page_lookup, site):

Check warning

Code scanning / CodeQL

Signature mismatch in overriding method Warning

Overriding method 'get_value' has signature mismatch with
overridden method
.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yakky yakky yakky requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@FinalAngel FinalAngel

@yakky yakky

Labels
needs tests status: accepted
Projects
None yet
Milestone
3.9.x
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ianare @coveralls @FinalAngel @yakky @czpython @goutnet @fsbraun