Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add RTL support to pagetree #7842

Merged

Conversation

sakhawy
Copy link
Contributor

@sakhawy sakhawy commented Mar 16, 2024

Description

Adding RTL support to pagetree for v3
Screenshot from 2024-03-16 05-58-31
Screenshot from 2024-03-16 05-58-49
Screenshot from 2024-03-16 05-59-02

Related resources

Checklist

- Use logical properties and `[dir=rtl]`
- Fix unsupported RTL styling in jsTree dnd marker
- Fix misc `changelist` RTL styling
@fsbraun fsbraun changed the title Fix: Add RTL support to pagetree feat: Add RTL support to pagetree Mar 16, 2024
Copy link
Sponsor Member

@fsbraun fsbraun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

@marksweb marksweb merged commit ab17db0 into django-cms:develop Mar 16, 2024
80 checks passed
fsbraun pushed a commit to fsbraun/django-cms that referenced this pull request May 12, 2024
* feat: add RTL support to pagetree

- Use logical properties and `[dir=rtl]`
- Fix unsupported RTL styling in jsTree dnd marker
- Fix misc `changelist` RTL styling

* fix: remove double semi-colon

* fix: remove keyword values in background-position
@Bashar
Copy link
Sponsor

Bashar commented Jul 18, 2024

amazing work @sakhawy Jazak Allah Khair brother :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants