Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Reintroduce default_plugins setting #7919

Merged
merged 6 commits into from
May 22, 2024
Merged

feat: Reintroduce default_plugins setting #7919

merged 6 commits into from
May 22, 2024

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented May 14, 2024 •
edited

Description

This PR undoes #6468 and fixes #7917.

The original reason for removal remains obscured to me.

  • The docs contain the feature
  • The release notes do not mention the removal (or at least I have not seen this)
  • Anyone not using it can remove it from their project by not using the setting

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined the channel #pr-reviews on our Discord Server to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from Aiky30 May 14, 2024 06:12
@fsbraun fsbraun mentioned this pull request May 14, 2024
Closed
2 tasks
@fsbraun fsbraun added the 4.1 label May 14, 2024
@fsbraun fsbraun requested a review from a team May 14, 2024 06:35
@fsbraun fsbraun requested a review from vinitkumar May 17, 2024 21:59
vinitkumar
vinitkumar approved these changes May 20, 2024
View reviewed changes
Copy link
Member

@vinitkumar vinitkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@fsbraun fsbraun merged commit 1fbe758 into django-cms:develop-4 May 22, 2024
80 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinitkumar vinitkumar vinitkumar approved these changes

@Aiky30 Aiky30 Awaiting requested review from Aiky30

Assignees
No one assigned
Labels
4.1
Projects
django CMS v4
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] PLACEHOLDER_CONF 'default_plugins' functionality removed.
2 participants
@fsbraun @vinitkumar