fix: Versioning-safe implementation of placeholder inheritance #7924
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
ContentRenderer.render_page_placeholders
implementation is not versioning-safe, i.e. assumes that there is exactly onePageContent
object perPage
and language. This PR improves the implementation using theadmin_manager
.This will allow
{% placeholder "my_placeholder" inherit %}
to also work with versioned page contents, such as provided by djangocms-versioning. (For it to actually work with djangocms-versioning, however, an additional change to djangocms-versioning is needed, to not deactivate the inherit functionality.)Results with djangocms-versioning:
Then changes are covered by tests. Additional tests need to go into djangocms-versioning if the inheritance feature is activated again.
Related resources
Checklist
develop-4