Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Django 4.2 admin support #500

Merged
merged 12 commits into from
Jan 3, 2024

Conversation

fsbraun
Copy link
Sponsor Member

@fsbraun fsbraun commented Oct 24, 2023

Django admin styles have changed. This fixes the delete-link styling and the readonly-fields styling

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ae6ec18) 100.00% compared to head (9c7ba4b) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #500   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           33        33           
  Branches         3         3           
=========================================
  Hits            33        33           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DmytroLitvinov
Copy link

Hi @fsbraun ,
Seems like that Pull Request can fix issue we have at our stage server when we upgraded to Django@4.2 and we have read-only fields.

I will look into details and let you know if it fixes so we can merge and release new version of djangocms-admin-style

@DmytroLitvinov
Copy link

@fsbraun , should it looks like that way?
image

@fsbraun
Copy link
Sponsor Member Author

fsbraun commented Jan 2, 2024

@DmytroLitvinov IMHO it should look like a form with editable fields, but the inputs replaced by the fields' values. Would you expect something else?

@DmytroLitvinov
Copy link

For me it is fine that it looks like that way.

Also attaching how it looks for Django@4.2 without djangocms-admin-style
image

@fsbraun
Copy link
Sponsor Member Author

fsbraun commented Jan 3, 2024

Yes, plain django admin style uses horizontal separation on large screens and vertical separation of label and field on small screens.

@vinitkumar OK for you, too? Can you review? 😎

@fsbraun fsbraun requested review from vinitkumar and a team January 3, 2024 14:16
@vinitkumar vinitkumar merged commit 7ee48a8 into django-cms:master Jan 3, 2024
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants