Fix AbstractPicture.get_size for portrait images #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We input a 1:2 image and set JUST a width limit. The output was a tiny image stretched to our original limit. and was getting out a bizarrely tiny image. This was due to two problems. - Only involve the Golden Ratio when you're cropping! - Use it in the right direction. When you have a portrait image, you need to inverse the ratio.
Codecov Report
@@ Coverage Diff @@
## master #98 +/- ##
===========================================
- Coverage 100.00% 98.00% -2.00%
===========================================
Files 14 14
Lines 246 251 +5
Branches 25 28 +3
===========================================
Hits 246 246
- Misses 0 2 +2
- Partials 0 3 +3
Continue to review full report at Codecov.
|
|
@oliwarner thank you very much for the PR. This seems legit and working. Would you be able to also:
|
This was referenced Aug 27, 2020
|
Is there any progress with this pull-request? |
|
@FinalAngel any change this (or better #100) gets merged ? |
|
@FinalAngel It would be nice, if this (or #100) gets merged, so I can go back to the upstream repository. |
|
@steffenmllr @mogoh I've just come across these PRs and merged #100 |
|
Change implemented through #100 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We input a 1:2 image and set JUST a width limit. The output was a tiny image stretched to our original limit. and was getting out a bizarrely tiny image. This was due to two problems.
This patch has been tested on our ~150 page CMS but I wouldn't for a second believe we use every feature of this plugin.