Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GitHub Actions #61

Merged
merged 3 commits into from
Apr 17, 2021
Merged

Add GitHub Actions #61

merged 3 commits into from
Apr 17, 2021

Conversation

crydotsnake
Copy link
Contributor

No description provided.

@marksweb marksweb merged commit 4de862b into django-cms:master Apr 17, 2021
@marksweb
Copy link
Member

@crydotsnake the requirements files were missing here.

I've jumped the gun on this. Can you please raise another PR with the requirements. The actions should run successfully on your branch before you need to raise the PR

@crydotsnake
Copy link
Contributor Author

@marksweb which requierements you mean?. tests/requirements.txt ?

@marksweb
Copy link
Member

@marksweb which requierements you mean?. tests/requirements.txt ?

No, that's what it used to use. These actions require a change to the requirements setup.

Take a look at one of the repos that I've already made this change on, or read through the test action. It shows the requirements files it needs and the path it expects to load them from.

@crydotsnake
Copy link
Contributor Author

@marksweb
Copy link
Member

You mean those files?: https://github.com/django-cms/djangocms-snippet/tree/master/tests/requirements

That's right. The old requirements.txt becomes the base which the others all import & define the other versions according to the file name.

That's then referenced in the test action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants