-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Force SDK 1.6.4. to save datastore on exit. #25
Conversation
…ine into ancestor
Actually, don't pull this. It works on dev_appserver, but not when deployed. |
Is this fork tested and ready to pull? |
It was, on 1.6.4, but I haven't tested on 1.6.5 yet. I think it's actually unnecessary on 1.6.5 since I believe they've fixed this issue in the SDK. |
I'm using 1.6.5, and have this issue without the fix you provided. On Wed, May 2, 2012 at 10:33 AM, dragonx <
|
Then I'm rather disappointed at the boys at Google. I'm pretty sure this fork is safe to pull at this point. |
…el/djangoappengine.git into feature/ancestor-query
I just tested on 1.6.5 on Linux, on a bad configuration where I'm using the python 2.5 runtime, but actually running python 2.7 locally. The problem is fixed with the SDK, so this change is now unnecessary - at least with "python manage.py shell". |
…ncy_probability in the testcase. The given consistency_probability will be used to configure the datastore. Otherwise, it's the same as django.test.TestCase.
Hi dragonx - Sorry for the delayed response. I am still having this issue, With the boot.py change, the entity persists across subsequent instances of Any ideas? On Sat, May 19, 2012 at 1:14 PM, dragonx <
|
jacobg, I'd report this to Google, they probably think the issue is fixed. 1.6.4 changed the dev_appserver datastore so that it was saved to disk on exit, and they only handled a few exit cases. They handled more exit cases in 1.6.5, so it seems like my situation is fixed (I run from the command prompt on Linux). I know that my patch didn't work for some users of eclipse in Windows - I haven't followed up on whether that's been fixed. The Terminate Failed message is a pretty big hint that dev_appserver is not happy with the way Aptana is shutting things down. Feel free to keep using the patch, but I think it's better if Google fixes it in their SDK. |
…branch. This means removing all the ancestor keys related changes, but this branch now passes all djangoappengine and djangotoolbox tests.
Two comments: jacobg, I've realized I'm seeing the same issue as you, when running runserver from the command prompt and killing it with Ctrl-C. That used to work even with 1.6.4, but it's broken for me now with 1.6.5. "python manage.py shell" works with 1.6.5 though. Can you verify that you're also seeing the issue from the command prompt? Also, what platform are you running on? Second, I've polluted this pull request with other commits in my branch. I don't know how to modify the pull request to limit it to a few checkins, so I'll probably launch a new pull request once I've figured this out. |
dragonx: It seems that the problem is just with runserver in Aptana on OS On Sat, May 26, 2012 at 11:32 AM, dragonx <
|
There's a couple of reports of various manage.py actions other than 'runserver' failing to save the datastore to disk. This change works around that and forces a flush on exit.