forwarding the original PayPal error message #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phedoreanu
force-pushed
the
master
branch
2 times, most recently
from
3765923
to
9ae6a92
Compare
ERROR Internal Server Error: /en/checkout/paypal/preview/5/
Traceback (most recent call last):
File "/virtenvs/test/lib/python2.7/site-packages/django/core/handlers/base.py", line 132, in get_response
response = wrapped_callback(request, *callback_args, **callback_kwargs)
File "/virtenvs/test/lib/python2.7/site-packages/django/utils/decorators.py", line 145, in inner
return func(*args, **kwargs)
File "/virtenvs/test/lib/python2.7/site-packages/django/views/generic/base.py", line 71, in view
return self.dispatch(request, *args, **kwargs)
File "/virtenvs/test/lib/python2.7/site-packages/oscar/apps/checkout/session.py", line 68, in dispatch
request, *args, **kwargs)
File "/virtenvs/test/lib/python2.7/site-packages/django/views/generic/base.py", line 89, in dispatch
return handler(request, *args, **kwargs)
File "/virtenvs/test/lib/python2.7/site-packages/paypal/express/views.py", line 200, in get
kwargs['basket'] = self.load_frozen_basket(kwargs['basket_id'])
File "/virtenvs/test/lib/python2.7/site-packages/paypal/express/views.py", line 231, in load_frozen_basket
Applicator().apply(self.request, basket)
File "/virtenvs/test/lib/python2.7/site-packages/oscar/apps/offer/applicator.py", line 26, in apply
offers = self.get_offers(basket, user, request)
File "/virtenvs/test/lib/python2.7/site-packages/oscar/apps/offer/applicator.py", line 58, in get_offers
basket_offers = self.get_basket_offers(basket, user)
File "/virtenvs/test/lib/python2.7/site-packages/oscar/apps/offer/applicator.py", line 94, in get_basket_offers
if not basket.id or not user:
AttributeError: 'WSGIRequest' object has no attribute 'id'
|
That's two lovely fixes in one, thanks! |
maiksprenger
added a commit
that referenced
this pull request
Nov 4, 2015
forwarding the original PayPal error message
This was referenced Nov 4, 2015
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple fix for displaying PayPal's original error message to the user.
Also included naming parameters - django-oscar 1.1 compatible.