Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome for mobile: menu content disappears under certain conditions #1109

Closed
itbabu opened this issue Dec 27, 2013 · 6 comments
Closed

Chrome for mobile: menu content disappears under certain conditions #1109

itbabu opened this issue Dec 27, 2013 · 6 comments

Comments

@itbabu
Copy link
Contributor

itbabu commented Dec 27, 2013

Enviroment: Android and chrome.

Steps:

  • click on the right top grey button or the black button on the black bar (the menu is open)
  • click again on the same button (the menu is closed)
  • click again (the menu is open but without content)

screenshot_2013-12-19-20-09-25

screenshot_2013-12-19-20-08-09

@ashiazed
Copy link

ashiazed commented Jan 7, 2014

This is a bug in Bootstrap 2.3.1 and 2.3.2.
The best way to fix it without overriding bootstrap files is to add this code after the responsive.css/less file
@media (max-width: 480px)
.nav-collapse {
-webkit-transform: none;
}
Not sure where to put the code though,end of the file? New less file with overrides?

@maiksprenger
Copy link
Member

I just added those changes to the bottom of layout.less, which I think is the right place. But while I could reproduce the issue, @laidibug fix didn't fix the issue for me on my Nexus 4. I did compile the CSS and clear the browser cache.

We'll happily accept a pull request for this.

@ashiazed
Copy link

ashiazed commented Jan 8, 2014

It won't work in the layout.less because it needs to overwrite the bootstrap responsive.less files which come after. I just found the perfect spot to put this so I'll make a pull request after work, plus do some additional testing.

maiksprenger pushed a commit that referenced this issue Jan 9, 2014
There's a bug in Bootstrap which affects the navbar when it's collapsed:
twbs/bootstrap#11145
This commit fixes the issue.

Fixes #1118, #1109
@maiksprenger
Copy link
Member

https://github.com/tangentlabs/django-oscar/pull/1118 should have fixed it. Thanks for reporting, @itbabu!

maiksprenger pushed a commit that referenced this issue Jan 23, 2014
There's a bug in Bootstrap which affects the navbar when it's collapsed:
twbs/bootstrap#11145
This commit fixes the issue.

Fixes #1118, #1109

(cherry picked from commit 2e72dd0)
@alexturpin
Copy link

I just wanted to thank all of you guys for this. Found this off Google, had been struggling with the same bug on my own project and it fixed it. Thanks again.

@maiksprenger
Copy link
Member

:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants