Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slashes excluded from group names #3

Closed
yourcelf opened this issue Jul 26, 2016 · 2 comments
Closed

Slashes excluded from group names #3

yourcelf opened this issue Jul 26, 2016 · 2 comments

Comments

@yourcelf
Copy link

c2d93f5 added validators to limit the characters allowed in group names. In our application, it's very natural to use the message.content['path'] (i.e. the URL) as a group name. This was working great until we upgraded and found that / is no longer a valid group name character.

Is there a good reason to exclude / from group names? If so, we'll add a translation to some other character. But if not, we'd love to see slashes added to the character class in group_name_regex.

@andrewgodwin
Copy link
Member

It was in particular in the case of groups being stored on some filesystem-backed store, where / is nearly always invalid. I'm unlikely to budge on this; can you find a way to translate the path into a group name programatically (e.g. with replacement)?

@yourcelf
Copy link
Author

Yup, makes sense, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants