Added note about culling in database cache backend docs. #13259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsasvipul0605
approved these changes
Aug 10, 2020
felixxm
changed the title
|
This should be ready for a second review. |
felixxm
reviewed
May 19, 2021
|
OK, I think this is ready for a third review. Thanks for the correction. How wrong I was! |
|
(I noticed a performance issue while looking at this code and opened a ticket: https://code.djangoproject.com/ticket/32772.) |
Co-authored-by: Mariusz Felisiak <felisiak.mariusz@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was quite confused how the DB cache was able to cull expired cache entries, asked on IRC and received this response. I think it'd be good to include this because others like me might be concerned that the timeout totally doesn't work on some backends. It does, of course (django is wonderful), and the implementation is clever enough to note.