Fixed #22635 -- Make "It worked!" page localizable #2682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -511,7 +512,20 @@ def technical_404_response(request, exception): | |||
| def default_urlconf(request): | |||
| "Create an empty URLconf 404 error response." | |||
| t = Template(DEFAULT_URLCONF_TEMPLATE, name='Default URLconf template') | |||
| c = Context({}) | |||
|
|
|||
| # The "It worked!" page should be localized, which happens by inserting | |||
There was a problem hiding this comment.
These comments seem unnecessary
There was a problem hiding this comment.
I'll remove it and make a new pull request.
There was a problem hiding this comment.
You can amend a PR, no need for a new one. see https://docs.djangoproject.com/en/dev/internals/contributing/writing-code/working-with-git/
Feel free to ask in #django-dev if you have any problems.
|
The commit message should be in past tense (Make -> Made). Also the "Fixed" bit is only in the PR title, not the actual commit message. |
|
Pushed to the branch, with fixes for all comments so far. |
claudep
added a commit
that referenced
this pull request
May 19, 2014
Fixed #22635 -- Make "It worked!" page localizable
|
Looks like this may have caused a regression. The |
|
Thanks, fixed in 43372fc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.