🐳 Refactor docker compose #1159
Conversation
|
I did a cursory review of it and it looks good. i'll need to download it and run it locally to see if I run into any issues (which will most likely be Friday or Saturday). @jefftriplett In terms of testing on production, if you need any help with trying to put out fires, let me know when you're thinking you'll be able to try it out and I can potentially be there with you if you're looking for an extra set of hands/eyes 😄 |
|
@ryancheley that'd be great. I'll probably do test it Friday if I don't get to it sooner. |
| @@ -10,7 +10,7 @@ You'll want to make sure your local environment is ready by installing the follo | |||
|
|
|||
| ### Docker | |||
|
|
|||
| If you don't have them installed yet, install [Docker] and [docker-compose]. | |||
| If you don't have them installed yet, install [Docker] and [Compose]. | |||
There was a problem hiding this comment.
Should we mention the minimum required versions here?
There was a problem hiding this comment.
Great idea. I don't know what the minimum should be.
| @@ -74,7 +74,7 @@ And then login into the admin interface (/admin/) and create a profile for your | |||
| We use a **Mock** system of creating sample data in our tests and for running a development version of the site. To create some development data, just run: | |||
|
|
|||
| ```shell | |||
| docker-compose run --rm django python manage.py load_dev_data | |||
| docker compose run --rm django python -m manage load_dev_data | |||
I need to remember that GitHub Codespaces are a thing! |
I need to remember this too. I eyeballed the change but Codespaces might be worth mentioning in our docs for our new djangonaut space recruits. |
* ✨ Adds pypi_update_top_package_stats management command * 🔥 Removes unused variable * ✨ Adds other management command * 🤝 Update package/management/commands/pypi_update_download_package_stats.py Co-authored-by: Maksudul Haque <saad.mk112@gmail.com> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * 🤝 Update package/management/commands/pypi_update_top_package_stats.py Co-authored-by: Maksudul Haque <saad.mk112@gmail.com> * 🤝 Update package/management/commands/pypi_update_top_package_stats.py Co-authored-by: Maksudul Haque <saad.mk112@gmail.com> * 🚜 Update package/management/commands/pypi_update_download_package_stats.py Co-authored-by: Maksudul Haque <saad.mk112@gmail.com> * 📝 Apply suggestions from code review Co-authored-by: Maksudul Haque <saad.mk112@gmail.com> * 🔥 Removes filename * 🚜 Applies PR feedback --------- Co-authored-by: Maksudul Haque <saad.mk112@gmail.com> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
|
🚀 and going to quick fix if I break all the things 😬 |
tl;dr Modern Compose drops the
docker-prefix and I'd like to make the project easier for our incoming new devs.I need to test in production to see if I can update
fabric.pyto the latest docker version when I have time to put out fires.